Repository navigation
Add dialog explaining future removal of Ideas tab - #1428
Merged
Merged
Conversation
|
Preview build will be at |
microbit-robert
commented
Nov 20, 2026
microbit-robert
commented
Nov 20, 2026
microbit-robert
commented
Nov 20, 2026
microbit-matt-hillsdon
self-requested a review
November 20, 2026 16:52
Ideas can now be browsed and opened from the home page as well as from the Ideas tab. Browsing from the sidebar is to be removed later. A notice under the Ideas tab heading says so, with a dialog giving what is changing, why and when.
Without the projects database, and in iframe controller mode, there is no home page for ideas to move to, but the notice and its dialog said they were moving there. They are now shown only where the home page exists. Also: - The questions section links to the deployment's support site in place of a hard-coded email address, and is left out where there is none. - "Home page" is capitalised throughout. - Opening the dialog is logged as ideas_notice_open. - The dialog's message ids are written out, so a search finds them. - Tests for the notice, the dialog and both cases without a home page, with accessibility scans of the two new states.
The icon was a fixed 16px beside 14.4px text and sat about 1.5px below the centre of the line. It now takes its size from the text and is centred in a box one line high.
microbit-matt-hillsdon
force-pushed
the
goodbye-ideas
branch
from
November 20, 2026 17:04
09cc2fc to
2538d65
Compare
microbit-matt-hillsdon
approved these changes
Nov 20, 2026
Collaborator
|
I had to rebase this to get github to show no merge conflicts even though there were none when I tried the merge locally. Bug in the new merge box maybe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideas can now be browsed and opened from the home page as well as from the editor's Ideas tab. This is an interim state: browsing from the sidebar is to be removed later, in mid-2027 as the dialog says. This tells users in advance.
What it adds
AreaHeadingtakes optional children, to hold the notice.Where it shows
Only where there is a home page for the ideas to move to. Without the projects database, and in iframe controller mode as classroom embeds the editor, there is no home page, so neither the notice nor the dialog appears.
The questions section uses the deployment's
supportLinkand is left out where a deployment has none.Opening the dialog is logged as
ideas_notice_open, added todocs/analytics-events.md.For review